Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dedicated ShutdownResult for Metric SDK shutdown #2573

Merged
merged 9 commits into from
Jan 31, 2025
Merged

Use dedicated ShutdownResult for Metric SDK shutdown #2573

merged 9 commits into from
Jan 31, 2025

Conversation

cijothomas
Copy link
Member

Trying to check how the changes discussed in
#2571 and #2564 would look like.
This touches just Metrics's Shutdown path.

@cijothomas cijothomas requested a review from a team as a code owner January 29, 2025 21:31
@codecov Codecov
Copy link

codecov bot commented Jan 29, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 51.02041% with 24 lines in your changes missing coverage. Please review.

Project coverage is 79.6%. Comparing base (b50da91) to head (8ab63bf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-otlp/src/exporter/http/metrics.rs 0.0% 5 Missing ⚠️
opentelemetry-otlp/src/exporter/tonic/metrics.rs 0.0% 5 Missing ⚠️
opentelemetry-sdk/src/metrics/manual_reader.rs 0.0% 4 Missing ⚠️
opentelemetry-sdk/src/metrics/periodic_reader.rs 62.5% 3 Missing ⚠️
opentelemetry-sdk/src/metrics/pipeline.rs 40.0% 3 Missing ⚠️
.../src/metrics/periodic_reader_with_async_runtime.rs 85.7% 2 Missing ⚠️
opentelemetry-otlp/src/metric.rs 0.0% 1 Missing ⚠️
opentelemetry-stdout/src/metrics/exporter.rs 0.0% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##            main   #2573     +/-   ##
=======================================
- Coverage   79.6%   79.6%   -0.1%     
=======================================
  Files        118     118             
  Lines      22473   22486     +13     
=======================================
+ Hits       17902   17906      +4     
- Misses      4571    4580      +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scottgerring scottgerring mentioned this pull request Jan 31, 2025
Closed
scottgerring
scottgerring approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@scottgerring scottgerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM and follows from our extensive discussions !
if you manage to merge it before the weekend, I could quickly do trace/logger Monday morning.

@cijothomas
Copy link
Member Author

Thanks @scottgerring . @lalitb could you do another review?

lalitb
lalitb approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. Thanks.

@cijothomas cijothomas merged commit 9dfcff1 into open-telemetry:main Jan 31, 2025
20 of 21 checks passed
@cijothomas cijothomas deleted the cijothomas/metric-shutdown branch January 31, 2025 18:20
@cijothomas
Copy link
Member Author

This LGTM and follows from our extensive discussions ! if you manage to merge it before the weekend, I could quickly do trace/logger Monday morning.

I'll continue to work on Metrics area only, to avoid conflicts, so you can do logs/trace side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottgerring scottgerring scottgerring approved these changes

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cijothomas @scottgerring @lalitb